Remove asmjs validation #11551
Merged
Remove asmjs validation #11551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, let's wait for fastcomp to be removed - the last version with fastcomp support should still support for asm.js validation, like always. |
|
I'm just not sure how much usage or testing this gets since it depends on spider monkey, and we don't install spider monkey on CI (or on local dev machines) that I know of. |
|
I've tested this locally, at least I've tried to when we make changes that could affect asm.js validation. It still works AFAIK. |
This only ever worked in spidermonkey and I don't think we care about asmjs validation anymore anyway. Perhaps this should wait until after we remove fastcomp which is the only route to generating valid asm.js that we still maintain.
sbc100
force-pushed
the
remove_asmjs_validation
branch
from
7a3068e to
6430d4e
Compare
|
The time as come ! |
kripken
approved these changes
Aug 11, 2020
|
See #11860 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only ever worked in spidermonkey and I don't think we care
about asmjs validation anymore anyway.
Perhaps this should wait until after we remove fastcomp which is the
only route to generating valid asm.js that we still maintain.