malloc(0) fails

[rillian]

Zero-length malloc calls assert. Since libc tends to return a valid pointer in this case, it's not uncommon. I found this particular one with one of the libogg framing.c unit tests from issue #115.

Calls to malloc(0) do succeed with --dlmalloc, but it would be nice if it were generally supported. Just allocate one space on the stack like you would for malloc(1)?

[rillian]

$ cat null-malloc.c
/** sample test to check malloc(0) behaviour */
#include <stdio.h>
#include <stdlib.h>

int test_malloc(int bytes)
{
char *p;

fprintf(stdout, "testing malloc(%d)...", bytes);
fflush(stdout);
p = malloc(bytes);
fprintf(stdout, "returned 0x%p\n", p);
fflush(stdout);
if (p) {
free(p);
return 0;
}

return 1;
}

int main(int argc, char *argv[])
{
int ret;

ret = test_malloc(1);
ret = test_malloc(0);

return ret;
}

[kripken]

Fixed in e2c5a4d, thanks for the bug report.

[rillian]

Confirmed, thanks!