Skip to content

Commit c143c22

Browse files
committed
remove redundant comments
1 parent be0dd29 commit c143c22

File tree

4 files changed

+2
-10
lines changed

4 files changed

+2
-10
lines changed

emcc.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1679,11 +1679,6 @@ def include_and_export(name):
16791679
# requires JS legalization
16801680
shared.Settings.LEGALIZE_JS_FFI = 0
16811681

1682-
# For STANDALONE_WASM and MINIMAL_RUNTIME mode that memory is creating
1683-
# in the module and exported to JS.
1684-
# In trandiational emscripten mode we create it in JS and export it to
1685-
# wasm. This allows us to set up memory, preload files, etc. even before
1686-
# the wasm module is created.
16871682
if shared.Settings.MINIMAL_RUNTIME or shared.Settings.STANDALONE_WASM:
16881683
shared.Settings.MEMORY_DEFINED_IN_WASM = 1
16891684

emscripten.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -620,9 +620,6 @@ def create_em_js(forwarded_json, metadata):
620620

621621

622622
def add_standard_wasm_imports(send_items_map):
623-
# Normally we import these into the wasm (so that JS could use them even
624-
# before the wasm loads), while in standalone mode we do not depend
625-
# on JS to create them, but create them in the wasm and export them.
626623
if not shared.Settings.MEMORY_DEFINED_IN_WASM:
627624
memory_import = 'wasmMemory'
628625
if shared.Settings.MODULARIZE and shared.Settings.USE_PTHREADS:

src/library_syscall.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1628,7 +1628,7 @@ for (var x in SyscallsLibrary) {
16281628
post += 'SYSCALLS.varargs = undefined;\n';
16291629
}
16301630
}
1631-
pre += "err('syscall! " + x + " ' + Array.prototype.slice.call(arguments));\n";
1631+
pre += "err('syscall! " + x + "');\n";
16321632
pre += "var canWarn = true;\n";
16331633
pre += "var ret = (function() {\n";
16341634
post += "})();\n";

tools/building.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -478,7 +478,7 @@ def lld_flags_for_executable(external_symbol_list):
478478
cmd.append('--allow-undefined')
479479

480480
if not Settings.MEMORY_DEFINED_IN_WASM:
481-
cmd.append('--importt-memory')
481+
cmd.append('--import-memory')
482482

483483
if Settings.USE_PTHREADS:
484484
cmd.append('--shared-memory')

0 commit comments

Comments
 (0)