Commit a5a76c3
committed
Fix other.test_embind_no_duplicate_symbols
After llvm/llvm-project#80282,
`formatter_integral.h` includes not `locale` but `_locale`
https://github.com/llvm/llvm-project/blame/aadaa00de76ed0c4987b97450dd638f63a385bed/libcxx/include/__format/formatter_integral.h#L35
and after several more include changes this causes
https://github.com/llvm/llvm-project/blob/aadaa00de76ed0c4987b97450dd638f63a385bed/libcxx/include/__thread/support/pthread.h
not to be included when
https://github.com/emscripten-core/emscripten/blob/main/system/include/emscripten/val.h
is included. `pthread.h` is where `pthread_t` is defined, which is used
here:
https://github.com/emscripten-core/emscripten/blob/fb14f6d9fc2b00fea36af0f5ca4e996f61520b8f/system/include/emscripten/val.h#L676
Until LLVM 18, the contents of
https://github.com/llvm/llvm-project/blob/aadaa00de76ed0c4987b97450dd638f63a385bed/libcxx/include/__thread/support/pthread.h
was in
https://github.com/llvm/llvm-project/blob/3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff/libcxx/include/__threading_support,
which was split off to several files in
llvm/llvm-project#79654. This file was
(transitively) included from `locale`.
Anyway, this commit just adds `#include <pthread.h>` directly to
`val.h`.1 parent d067393 commit a5a76c3
1 file changed
+1
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
0 commit comments