Update to latest version of flake8. NFC (#18009)

Author: sbc100

.flake8

@@ -1,5 +1,5 @@
 [flake8]
-ignore = E111,E114,E501,E261,E266,E121,E402,E241,W504,E741,B011
+ignore = E111,E114,E501,E261,E266,E121,E402,E241,W504,E741,B011,B023,U101
 exclude =
  ./third_party/, # third-party code
  ./tools/filelock.py, # third-party code

emcc.py

@@ -4035,7 +4035,7 @@ def parse_string_list_members(text):
       if not len(current):
         exit_with_error('string array should not contain an empty value')
       first = current[0]
-      if not(first == "'" or first == '"'):
+      if not (first == "'" or first == '"'):
         result.append(current.rstrip())
       else:
         start = index

emrun.py

@@ -1360,7 +1360,7 @@ def subprocess_env():
 def remove_tree(d):
   os.chmod(d, stat.S_IWRITE)
   try:
-    def remove_readonly_and_try_again(func, path, exc_info):
+    def remove_readonly_and_try_again(func, path, _exc_info):
       if not (os.stat(path).st_mode & stat.S_IWRITE):
         os.chmod(path, stat.S_IWRITE)
         func(path)

emscripten.py

@@ -328,7 +328,7 @@ def emscript(in_wasm, out_wasm, outfile_js, memfile):
         c_sig = c_sig.split(',')
       if em_js_func in import_map:
         imp = import_map[em_js_func]
-        assert(imp.kind == webassembly.ExternType.FUNC)
+        assert imp.kind == webassembly.ExternType.FUNC
         signature = types[imp.type]
         if len(signature.params) != len(c_sig):
           diagnostics.warning('em-js-i64', 'using 64-bit arguments in EM_JS function without WASM_BIGINT is not yet fully supported: `%s` (%s, %s)', em_js_func, c_sig, signature.params)

requirements-dev.txt

@@ -4,9 +4,9 @@
 # the codebase and generate docs using Sphinx, not for users of emscripten.
 # Install with `pip3 install -r requirements-dev.txt`
 
-flake8==3.9.0
-flake8-bugbear==22.4.25
-flake8-unused-arguments==0.0.6
+flake8==5.0.4
+flake8-bugbear==22.9.23
+flake8-unused-arguments==0.0.11
 coverage==5.5
 mypy==0.971
 types-requests==2.27.14

test/common.py

@@ -1753,8 +1753,8 @@ def btest_exit(self, filename, assert_returncode=0, *args, **kwargs):
     REPORT_RESULT macro to the C code.
     """
     self.set_setting('EXIT_RUNTIME')
-    assert('reporting' not in kwargs)
-    assert('expected' not in kwargs)
+    assert 'reporting' not in kwargs
+    assert 'expected' not in kwargs
     kwargs['reporting'] = Reporting.JS_ONLY
     kwargs['expected'] = 'exit:%d' % assert_returncode
     return self.btest(filename, *args, **kwargs)

test/jsrun.py

@@ -93,7 +93,7 @@ def run_js(filename, engine, args=None,
   """Execute javascript code generated by tests, with possible timeout."""
 
   # We used to support True here but we no longer do.  Assert here just in case.
-  assert(type(assert_returncode) == int)
+  assert type(assert_returncode) == int
 
   if not os.path.exists(filename):
     raise Exception('output file not found: ' + filename)

test/test_other.py

@@ -7463,11 +7463,11 @@ def run_metadce_test(self, filename, args=[], expected_exists=[], expected_not_e
     # find the imports we send from JS
     js = read_file('a.out.js')
     start = js.find('asmLibraryArg = ')
-    assert(start != -1)
+    assert start != -1
     end = js.find('}', start)
-    assert(end != -1)
+    assert end != -1
     start = js.find('{', start)
-    assert(start != -1)
+    assert start != -1
     relevant = js[start + 2:end - 1]
     relevant = relevant.replace(' ', '').replace('"', '').replace("'", '').split(',')
     sent = [x.split(':')[0].strip() for x in relevant]
@@ -11530,7 +11530,7 @@ def create_o(name, i):
     main = '#include<stdio.h>\n%s int main() { int value = 0; %s printf("%%d\\n", value); }' % (decls, calls)
     open('main.c', 'w').write(main)
 
-    assert(sum(len(f) for f in files) > 32767)
+    assert sum(len(f) for f in files) > 32767
 
     self.run_process(building.get_command_with_possible_response_file([EMCC, 'main.c'] + files))
     self.assertContained(str(count * (count - 1) // 2), self.run_js('a.out.js'))

tools/colored_logger.py

@@ -72,15 +72,15 @@ def new(*args):
     BACKGROUND_GREY      = 0x0070 # noqa
     BACKGROUND_INTENSITY = 0x0080 # background color is intensified.
     levelno = args[1].levelno
-    if(levelno >= 50):
+    if (levelno >= 50):
         color = BACKGROUND_YELLOW | FOREGROUND_RED | FOREGROUND_INTENSITY | BACKGROUND_INTENSITY
-    elif(levelno >= 40):
+    elif (levelno >= 40):
         color = FOREGROUND_RED | FOREGROUND_INTENSITY
-    elif(levelno >= 30):
+    elif (levelno >= 30):
         color = FOREGROUND_YELLOW | FOREGROUND_INTENSITY
-    elif(levelno >= 20):
+    elif (levelno >= 20):
         color = FOREGROUND_GREEN
-    elif(levelno >= 10):
+    elif (levelno >= 10):
         color = FOREGROUND_MAGENTA
     else:
         color = FOREGROUND_WHITE

tools/shared.py

@@ -644,7 +644,7 @@ def strip_prefix(string, prefix):
 
 
 def make_writable(filename):
-  assert(os.path.isfile(filename))
+  assert os.path.isfile(filename)
   old_mode = stat.S_IMODE(os.stat(filename).st_mode)
   os.chmod(filename, old_mode | stat.S_IWUSR)