Commit e20c0e4
Robert Jackson
Fix compatibility with Ember 3.27+ when using compileModules: false.
When using libraries that leverage `compileModules: false` (commonly
used to transpile `vendor` tree's without introducing a wrapping AMD
module) on Ember 3.27+ (where we don't transpile away the various
`@ember/*` modules any longer) we would leave the debug module imports
alone during transpilation. This resulted (in most cases) in there being
a bare unwrapped and untranspiled `import` statement in `vendor.js`.
This would then fail **everything**.
This changes the logic slightly to continue transpiling to globals mode
when `compileModules: false` is set.
Note: this is really just a stop gap solution (and will still cause
deprecations to be emitted, addons that are currently leveraging
`compileModules: false` _will_ need to make some changes for Ember 4.0
(where a global `window.Ember` will not be ambiently available).1 parent 917f86b commit e20c0e4
2 files changed
+63
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
89 | 91 | | |
90 | 92 | | |
91 | 93 | | |
| |||
420 | 422 | | |
421 | 423 | | |
422 | 424 | | |
423 | | - | |
| 425 | + | |
424 | 426 | | |
425 | 427 | | |
426 | 428 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
457 | 457 | | |
458 | 458 | | |
459 | 459 | | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
460 | 519 | | |
461 | 520 | | |
462 | 521 | | |
| |||
0 commit comments