Skip to content

Use ad- tailwind prefix #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2018
Merged

Conversation

jrowlingson
Copy link
Contributor

Addresses #178

Yes - we should probably prefix the Tailwind classes we're using, perhaps with ad- so they don't conflict.

cc @samselikoff

@samselikoff
Copy link
Contributor

@pzuraq @dfreeman I'm 👍 on this but understand why people might hate me for it 😄

I have a future in mind where this sort of thing is done at build-time, so we still get to use vanilla classes but they're prefixed when the addon is used by others. But for now I think this change makes us a better citizen.

In retrospect Tailwind may not have been the best choice for styling this addon for these sorts of issues (it's hard to contain, based on global utilities, etc.) but I still do think it has many strengths for a project like this, notably preventing css debt from growing over time.

Hopefully I (or someone else) can eventually add these build-time features to ember-cli-tailwind in the future.

@pzuraq
Copy link
Contributor

pzuraq commented Jul 27, 2018

I 👍 as well, the only thing that bothers me occasionally about Tailwind is it makes customizing addon-docs' CSS hard, but tbh that's a good thing because it makes me fix things upstream more often 😛

Let's move forward with this for now

@samselikoff samselikoff merged commit 90ee2d5 into ember-learn:master Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants