Skip to content

Use NPM instead of Yarn #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 28, 2022
Merged

Use NPM instead of Yarn #835

merged 5 commits into from
Nov 28, 2022

Conversation

MinThaMie
Copy link
Contributor

No description provided.

@chriskrycho
Copy link
Contributor

Seems fine to me as an outside contributor: I don't especially care. However, there are a couple things to consider when evaluating this as an alternative to either upgrading to Yarn 3 or switching to pnpm:

  • While npm's performance has improved, such that it is now comparable to Yarn 1, it is still much, much slower than Yarn 3 or pnpm. That is not a make or break thing, but it is a really nice win as a contributor.

  • Unfortunately, npm still does not handle peerDependencies very well, while both Yarn 3 and pnpm have significantly improved in that area. We are steadily working (especially as part of Embroider) to make ember-source and other core packages be well-behaved Node packages in terms of how they and libraries which use them get folded together by standard build tools, and that means a lot more uses of peerDependencies (roughly: there should only be one actual copy of Ember itself in the thing you build!).

Net, while npm is fine, and has the not insignificant upside of being bundled with Node, I am encouraging folks in general across the community (not just in this app!) to look at using either Yarn 3 or pnpm, both of which are also increasingly easy to use (and provide good DX to users out of the box) courtesy of corepack.

@MinThaMie
Copy link
Contributor Author

Thanks for you elaborate explanation :) Let's see what the rest things of this. We discussed it yesterday in the learning-meeting and would prefer to move to NPM first and who knows when we would move to pnpm

@mansona mansona force-pushed the npm-instead-of-yarn branch 2 times, most recently from 9c4d6d7 to 656a77d Compare November 22, 2022 10:21
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @MinThaMie 🎉 very happy to see this

@mansona mansona force-pushed the npm-instead-of-yarn branch from 3126adc to 38cf235 Compare November 25, 2022 14:08
@MinThaMie
Copy link
Contributor Author

Approved during the 28-11-2022 learning core meeting

@MinThaMie MinThaMie merged commit bd1aad6 into master Nov 28, 2022
@MinThaMie MinThaMie deleted the npm-instead-of-yarn branch November 28, 2022 16:38
@jenweber jenweber mentioned this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants