Skip to content

Common issues transfer #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2018

Conversation

BradenLawrence
Copy link
Contributor

Add common issues markdown from ember-cli.com

Copy link

@sandstrom sandstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 💯

A few thoughts below

@@ -1 +1,127 @@
<!-- copy over from ember-cli.com -->
### `npm` Package Management with `sudo`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

### Don't install `npm` packages with `sudo`

That way the heading is self-explanatory?

### Using Canary Build instead of release

For Ember: `bower install ember#canary --resolution canary`
For `ember-data`: `npm install --save-dev emberjs/data#master`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about some more color? E.g. "In most cases you should use a stable release, but if you need to install a canary version to test beta features, you'd do it like this:"


In order to fix this ensure the following is added to your `PATH`:

`C:\Users\USER_NAME\AppData\Roaming\npm\node_modules\phantomjs\lib\phantom`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is PhantomJS still used?

emberjs/ember.js@0a5388b

When building your own [Docker](http://docker.com) image to build Ember
applications and run tests, there are a couple of pitfalls to avoid.

* PhantomJS requires `bzip2` and `fontconfig` to already be installed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is PhantomJS still used? emberjs/ember.js@0a5388b

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say we remove PhantomJS from our documentation. It’s not been part of blueprints forever.


### Usage with Vagrant

[Vagrant](http://vagrantup.com) is a system for automatically creating and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: http -> https

@jenweber
Copy link
Contributor

jenweber commented Oct 6, 2018

@sandstrom thanks so much for helping review some PRs!

 - Clarify the heading for the npm packages section
 - Add a description for the Canary build section
 - Remove PhantomJS section
 - Fix the link to Vagrant to include https
@BradenLawrence
Copy link
Contributor Author

Thanks for the review @sandstrom! I just added in your changes. The rest of the sections already had descriptions, so I didn't add anything else to color them. Let me know if you have any suggestions!

 - Commenting out Docker section until it can be rewritten without using PhantomJS
@jenweber jenweber merged commit b3d01d2 into ember-learn:master Oct 11, 2018
@jenweber
Copy link
Contributor

Merged 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants