-
-
Notifications
You must be signed in to change notification settings - Fork 76
Common issues transfer #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common issues transfer #12
Conversation
- Addressing issue ember-learn#3, item 10, "Port over Common Issues. Mostly copy and paste from this source code" - Converted the markdown file found here: https://raw.githubusercontent.com/ember-cli/ember-cli.github.io/master/_posts/2013-04-03-common-issues.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 💯
A few thoughts below
guides/reference/common-issues.md
Outdated
@@ -1 +1,127 @@ | |||
<!-- copy over from ember-cli.com --> | |||
### `npm` Package Management with `sudo` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
### Don't install `npm` packages with `sudo`
That way the heading is self-explanatory?
### Using Canary Build instead of release | ||
|
||
For Ember: `bower install ember#canary --resolution canary` | ||
For `ember-data`: `npm install --save-dev emberjs/data#master` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about some more color? E.g. "In most cases you should use a stable release, but if you need to install a canary version to test beta features, you'd do it like this:"
guides/reference/common-issues.md
Outdated
|
||
In order to fix this ensure the following is added to your `PATH`: | ||
|
||
`C:\Users\USER_NAME\AppData\Roaming\npm\node_modules\phantomjs\lib\phantom` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is PhantomJS still used?
guides/reference/common-issues.md
Outdated
When building your own [Docker](http://docker.com) image to build Ember | ||
applications and run tests, there are a couple of pitfalls to avoid. | ||
|
||
* PhantomJS requires `bzip2` and `fontconfig` to already be installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is PhantomJS still used? emberjs/ember.js@0a5388b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I say we remove PhantomJS from our documentation. It’s not been part of blueprints forever.
guides/reference/common-issues.md
Outdated
|
||
### Usage with Vagrant | ||
|
||
[Vagrant](http://vagrantup.com) is a system for automatically creating and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: http -> https
@sandstrom thanks so much for helping review some PRs! |
- Clarify the heading for the npm packages section - Add a description for the Canary build section - Remove PhantomJS section - Fix the link to Vagrant to include https
Thanks for the review @sandstrom! I just added in your changes. The rest of the sections already had descriptions, so I didn't add anything else to color them. Let me know if you have any suggestions! |
- Commenting out Docker section until it can be rewritten without using PhantomJS
Merged 🎉 |
Add common issues markdown from ember-cli.com