Speedup parsing lengths by exploiting float32 vs. uint32 structure #1
+381
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @emanuele, I believe I found a way to improve the speed for parsing the streamline lengths. It might need more testing, but I thought I would share it with you anyway.
Here are the results I get on my laptop (with SSD). The relevant parts are
load_trk_newer.py
andload_trk_no_numba.py
. I also added a checksum to make sure the loaded streamlines are the same for all methods (Checksum: 28226791454.458008
).