fix(fontlock): only re-fontify method calls with reserved words #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions can not be called after a reserved word such as `if` or `delete`, however methods can. Only re-apply fontification on methods.
josteink
approved these changes
Aug 5, 2022
|
Thanks! It has better test coverage and build is still green. Consider it merged! |
|
For the future reference: this patch basically undid my previous "fix" and only applied it on methods, as it makes no sense on functions since those are protected by typescript itself (so nobody would write such code). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions can not be called after a reserved word such as
ifordelete, however methods can. Only re-apply fontification onmethods.
Fixes #174