feat(fontlock): fontify arrow fn arguments #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I got around to do class methods as well
Also made sure keywords are still fontified as variables when in variable context
|
Fuco1
force-pushed
the
feature/fontify-arrow-fn-args
branch
from
4e709df to
d6fa23f
Compare
The function font-lock-fontify-buffer is only for interactive use.
Fuco1
force-pushed
the
feature/fontify-arrow-fn-args
branch
from
d6fa23f to
e007a1b
Compare
Fuco1
changed the title
Fuco1
force-pushed
the
feature/fontify-arrow-fn-args
branch
from
e007a1b to
a915a08
Compare
Fuco1
force-pushed
the
feature/fontify-arrow-fn-args
branch
from
a915a08 to
84bab53
Compare
Fuco1
changed the title
|
This change is above my paygrade to review, but from what I can tell you've added test-cases and none of the existing one are failing. Looks good to me, I guess? 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fontify the variables in arrow function argument lists.
Probably won't work 100% because parsing with regexps is hard but 80/20 applies.
Before
After