-
-
Notifications
You must be signed in to change notification settings - Fork 916
Add lsp-gunzip function to decompress gzipped files #2400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also add decompress key to lsp-download-install so that dependencies can decompress themselves with lsp-unzip/lsp-gunzip
Otherwise, LGTM. Perhaps @yyoncho might have some more comments. Thank you for contributing! |
@kiennq - can you help with this? |
Actually, I just realized that PowerShell works on linux as well. I will come up with a proposal. |
There is Expand-Archive. |
Co-authored-by: Nikita Bloshchanevich <[email protected]>
Co-authored-by: Nikita Bloshchanevich <[email protected]>
|
Code looks good to me. The only thing that is missing is the windows scripts. I found this - https://scatteredcode.net/download-and-extract-gzip-tar-with-powershell/ which has gzip script but it seems like it can be used only on windows since it depends on .net(might be wrong). I think that we can merge it as it is if we change the error message:
This way the user can continue the installation manually. |
@@ -40,6 +40,7 @@ | |||
(require 'ht) | |||
(require 'imenu) | |||
(require 'inline) | |||
(require 'jka-compr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leftover
Thank you! |
Also add the
:decompress
argument to lsp-download-install so that dependencies can decompress themselves.My main use case is to be able to download binaries for
lsp-haskell.el
, which has the binaries compressed with gzip. This way we can use dependencies like:So far I haven't add a script for windows Powershell yet, as I don't have a windows machine to test this on.