Skip to content

Disabling completion snippets does not work (anymore) #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hpdeifel opened this issue Jun 21, 2021 · 2 comments
Closed

Disabling completion snippets does not work (anymore) #126

hpdeifel opened this issue Jun 21, 2021 · 2 comments

Comments

@hpdeifel
Copy link
Contributor

Setting lsp-haskell-completion-snippets-on to nil (and restarting the server) has no effect when using the latest haskell-language-server (1.2.0).

This is probably caused by haskell/haskell-language-server#1619 which was introduced in 1.1.0 and changed the setting name from haskell.completionSnippetsOn to the intuitively named haskell.plugin.ghcide-completions.config.snippetsOn.


Doing

(lsp-register-custom-settings
  '(("haskell.plugin.ghcide-completions.config.snippetsOn" lsp-haskell-completion-snippets-on t)))

worked for me to fix it.

@michaelpj
Copy link
Collaborator

Thanks, good point, we need to regenerate all these things to make them match the new config options.

Of course, that will break old HLSs, but I don't think we can realistically keep compatibility, especially given the pace of change right now. Caveat emptor!

@michaelpj
Copy link
Collaborator

Fixed, finally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants