First steps towards DB Connection #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 20, 2021
|
If you go take a look at #1 you'll see that I follow |
warmwaffles
reviewed
Feb 20, 2021
|
|
||
| # TODO: handle/track SAVEPOINT | ||
| case Keyword.get(opts, :mode, :deferred) do | ||
| :immediate -> handle_transaction(:begin, "BEGIN IMMEDIATE TRANSACTION", state) |
There was a problem hiding this comment.
cool I completely forgot about these modes for the transaction 👍🏻
warmwaffles
approved these changes
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've split this into many small commits :D
I'm now stuck withI finally figured it out in #3 🙄handle_executebecause Sqlite3 expects a SQL statement, butpreparereturns a reference. Haven't looked into this yet.I'm following myxql somewhat closely, but currently only implementing the most barebone functionality. Also see inline #TODO comments
I've tested what I have so far manually.