Update error message to match on OTP 24 #47
Conversation
| @@ -2370,9 +2370,20 @@ defmodule Ecto.Adapters.SQLite3.ConnectionTest do | |||
| end | |||
|
|
|||
| test "create table with an unsupported type" do | |||
| msg = | |||
There was a problem hiding this comment.
I actually think it is fine to just return the multi string error message regardless of OTP version.
There was a problem hiding this comment.
The error message afaik is not in our control. The difference is due to improvments on error messages for NIFs and BIFs, which are part of OTP24.
There was a problem hiding this comment.
Ah I see. I don't think inside the NIF we raise any exceptions there, just return atom error tuples. 👍🏻
|
@LostKobrakai I updated our workflow to include OTP24, 23, and 22 tests and we have two failures around this. I don't think it was introduced by you. Probably something left over in a test that we forgot about. #54 |
|
It might be that the new errors not only need OTP24, but also some integration in elixir 1.12 |
|
Perhaps the better solution @LostKobrakai would be to remove the message for the assertion? |
No description provided.