-
Notifications
You must be signed in to change notification settings - Fork 52
SQLite Update to get it closer to Postgres with ecto. #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQLite Update to get it closer to Postgres with ecto. #101
Conversation
Exciting. |
@jeregrine how's this coming along? |
query: query, | ||
message: "join hints are not supported by SQLite3" | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should Enum.map(hints, &[?\s | &1]),
be removed from the iolist below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
96abca9
to
f2a61ed
Compare
@warmwaffles I fixed the merge conflicts but integration tests will continue to fail until a new ecto version is cut with this in it elixir-ecto/ecto#4083 |
Ah no problem then. Let's wait for them to cut a new version. There shouldn't be too many merge conflicts until then. |
Are we ready to go? Or should we merge #107 instead? |
I want to give you all the credit for the work you did here. When I squash merge #107, it will consolidate under @fredwu's name. What I can do is just bump to ecto 3.10, then you rebase this on top. Then @fredwu rebase his work after we merge your work @jeregrine. How does that sound? |
Actually @jeregrine let me just squash merge this and @fredwu can just rebase on top. |
I'm bringing the discussion here, changes so far and work todo
distinct: true
only