Skip to content

Introduce status/2 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 49 additions & 9 deletions integration_test/cases/transaction_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -776,8 +776,8 @@ defmodule TransactionTest do
test "transaction logs begin :commit and :rollback" do
stack = [
{:ok, :state},
{:commit, :new_state},
{:rollback, :newer_state},
{:transaction, :new_state},
{:error, :newer_state},
]
{:ok, agent} = A.start_link(stack)

Expand All @@ -791,7 +791,7 @@ defmodule TransactionTest do
[log: log]) == {:error, :rollback}

assert_received %DBConnection.LogEntry{call: :begin} = entry
err = DBConnection.TransactionError.exception(:commit)
err = DBConnection.TransactionError.exception(:transaction)
assert %{query: :begin, params: nil, result: {:error, ^err}} = entry
assert is_integer(entry.pool_time)
assert entry.pool_time >= 0
Expand All @@ -805,7 +805,7 @@ defmodule TransactionTest do
[log: log]) == {:error, :rollback}

assert_received %DBConnection.LogEntry{call: :begin} = entry
err = DBConnection.TransactionError.exception(:rollback)
err = DBConnection.TransactionError.exception(:error)
assert %{query: :begin, params: nil, result: {:error, ^err}} = entry
assert is_integer(entry.pool_time)
assert entry.pool_time >= 0
Expand All @@ -825,9 +825,9 @@ defmodule TransactionTest do
stack = [
{:ok, :state},
{:ok, :began, :new_state},
{:begin, :newer_state},
{:idle, :newer_state},
{:ok, :began, :newest_state},
{:rollback, :state2},
{:error, :state2},
{:ok, :rolledback, :new_state2}
]
{:ok, agent} = A.start_link(stack)
Expand All @@ -843,7 +843,7 @@ defmodule TransactionTest do
[log: log]) == {:error, :rollback}

assert_received %DBConnection.LogEntry{call: :commit} = entry
err = DBConnection.TransactionError.exception(:begin)
err = DBConnection.TransactionError.exception(:idle)
assert %{query: :commit, params: nil, result: {:error, ^err}} = entry
assert is_nil(entry.pool_time)
assert is_integer(entry.connection_time)
Expand Down Expand Up @@ -878,7 +878,7 @@ defmodule TransactionTest do
stack = [
{:ok, :state},
{:ok, :began, :new_state},
{:begin, :newer_state}
{:idle, :newer_state}
]
{:ok, agent} = A.start_link(stack)

Expand All @@ -896,7 +896,7 @@ defmodule TransactionTest do
[log: log]) == {:error, :oops}

assert_received %DBConnection.LogEntry{call: :rollback} = entry
err = DBConnection.TransactionError.exception(:begin)
err = DBConnection.TransactionError.exception(:idle)
assert %{query: :rollback, params: nil, result: {:error, ^err}} = entry
assert is_nil(entry.pool_time)
assert is_integer(entry.connection_time)
Expand Down Expand Up @@ -953,4 +953,44 @@ defmodule TransactionTest do
handle_begin: [_, :state2],
handle_rollback: [_, :new_state2]] = A.record(agent)
end

test "status returns result" do
err = RuntimeError.exception("oops")
stack = [
{:ok, :state},
{:idle, :new_state},
{:transaction, :newer_state},
{:error, :newest_state},
{:disconnect, err, :state2},
:ok,
fn(opts) ->
send(opts[:parent], :reconnected)
{:ok, :new_state2}
end,
]
{:ok, agent} = A.start_link(stack)

opts = [agent: agent, parent: self()]
{:ok, pool} = P.start_link(opts)

assert P.status(pool, opts) == :idle
assert P.status(pool, opts) == :transaction
assert P.run(pool, fn(conn) ->
assert P.status(pool, [queue: false] ++ opts) == :error
assert P.status(conn, opts)
end, opts)
assert P.status(pool, opts) == :error

assert_receive :reconnected

assert [
connect: [_],
handle_status: [ _, :state],
handle_status: [_, :new_state],
handle_status: [_, :newer_state],
handle_status: [_, :newest_state],
disconnect: [^err, :state2],
connect: [_]
] = A.record(agent)
end
end
Loading