Skip to content

Commit 24dc7ad

Browse files
authored
Merge pull request #48 from elbformat/php84-deprecation
Fix deprecation warning
2 parents 0fe4977 + 9151cc1 commit 24dc7ad

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

doc/changelog.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Changelog
22

3+
## v1.5.8
4+
* Fix: Deprecation warning for implicit nullable parameter.
5+
36
## v1.5.7
47
* Feature/Fix: Support json arrays in AbstractDatabaseContext
58

src/Context/DomTrait.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ protected function createNotFoundException(string $what, ?Crawler $fallbacks = n
3434
/** @var DOMNamedNodeMap $fallbackAttributes */
3535
$fallbackAttributes = $fallback->attributes;
3636
/** @var DOMAttr $attribute */
37-
foreach($fallbackAttributes as $attribute) {
37+
foreach ($fallbackAttributes as $attribute) {
3838
$attribs .= sprintf(' %s="%s"', $attribute->nodeName, $attribute->value);
3939
}
4040
$foundTag = sprintf('<%s%s>...%s...</%1$s>', $fallback->nodeName, $attribs, $fallback->textContent);

src/Context/FormContext.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ public function theFormContainsASelect(TableNode $attribs): void
208208

209209
#[Then('select :select contains option')]
210210
#[Then('select :select contains option :label')]
211-
public function selectContainsOption(string $select, string $label = null, ?TableNode $tableNode = null): void
211+
public function selectContainsOption(string $select, ?string $label = null, ?TableNode $tableNode = null): void
212212
{
213213
$crawler = $this->getLastFormCrawler();
214214
if (null !== $label) {

0 commit comments

Comments
 (0)