Fix issues with deserializing mappings #829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the server. We need to make sure that we can deserialize the interfaces on the RootObjectMapping, which requires specifying ResolveAsTypeConverter on all the appropriate interfaces. I added a test as well, though I'm not sure it's in the right place, and I added a Deserialize function on TestElasticClient to make it easier to roundtrip the serialization.
Author
|
To be clear, the issue here was that it would throw a SerializationException because it couldn't deserialize to an interface. I can file an issue if we want to do that for book-keeping. |
Contributor
|
Yikes, good catch @johndaniels. Thank you for finding and fixing this. An issue won't be necessary, I can mark this PR with the |
gmarz
added a commit
that referenced
this pull request
Jul 25, 2014
Fix issues with deserializing mappings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure that we can deserialize the interfaces on the
RootObjectMapping, which requires specifying ResolveAsTypeConverter
on all the appropriate interfaces. I added a test as well, though I'm
not sure it's in the right place, and I added a Deserialize function
on TestElasticClient to make it easier to roundtrip the serialization.
I'm not sure if that was the right place to put the test, or the right approach, but it seemed like a good idea to have tests for whether we can serialize/deserialize RootObjectMapping.