Avoid some uses of ConcurrentLinkedQueue.size() in SharedBlobCacheService #128119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SharedBlobCacheService keeps track of the free regions in a ConcurrentLinkedQueue. We use its "size()" method in three places outside of tests but unfortunately this is not a constant time operation because of the asynchronous nature of this queue. This change removes two of the uses where we only check if the queue is empty by calling the "isEmpty()" method instead.
cbuescher
added
:Distributed Indexing/Distributed
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
elasticsearchmachine
added
the
Team:Distributed Indexing
|
Fyi, this came up while profiling a new use of "maybeFetchRange" in ESS where we saw a majority of the call was used by calling "SharedBlobCacheService#freeRegionCount" |
|
Hi @cbuescher, I've created a changelog YAML for you. |
|
@elasticmachine update branch |
|
There are no new commits on the base branch. |
andreidan
approved these changes
May 19, 2025
Good call, the method is already package private and from the current doc comment should have been only used by tests. I'll remove that doc and make it even clearer that this isn't constant-time. |
|
@tlrx Andrei just made a good point about whether it makes sense to backport this change to 9.0 and 8.19. If you don't disagree for some reason I would do that later today. Let me know if you think otherwise. |
|
All good for me to backport. |
cbuescher
added a commit
to cbuescher/elasticsearch
that referenced
this pull request
May 20, 2025
…vice (elastic#128119) SharedBlobCacheService keeps track of the free regions in a ConcurrentLinkedQueue. We use its "size()" method in three places outside of tests but unfortunately this is not a constant time operation because of the asynchronous nature of this queue. This change removes two of the uses where we only check if the queue is empty by calling the "isEmpty()" method instead.
|
Backport PR to 9.0 and 8.19: #128194 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 20, 2025
…vice (#128119) (#128194) SharedBlobCacheService keeps track of the free regions in a ConcurrentLinkedQueue. We use its "size()" method in three places outside of tests but unfortunately this is not a constant time operation because of the asynchronous nature of this queue. This change removes two of the uses where we only check if the queue is empty by calling the "isEmpty()" method instead.
cbuescher
added a commit
to cbuescher/elasticsearch
that referenced
this pull request
May 20, 2025
…vice (elastic#128119) (elastic#128194) SharedBlobCacheService keeps track of the free regions in a ConcurrentLinkedQueue. We use its "size()" method in three places outside of tests but unfortunately this is not a constant time operation because of the asynchronous nature of this queue. This change removes two of the uses where we only check if the queue is empty by calling the "isEmpty()" method instead.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 20, 2025
…vice (#128119) (#128194) (#128203) SharedBlobCacheService keeps track of the free regions in a ConcurrentLinkedQueue. We use its "size()" method in three places outside of tests but unfortunately this is not a constant time operation because of the asynchronous nature of this queue. This change removes two of the uses where we only check if the queue is empty by calling the "isEmpty()" method instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SharedBlobCacheService keeps track of the free regions in a ConcurrentLinkedQueue. We use its "size()" method in three places outside of tests but unfortunately this is not a constant time operation because of the asynchronous nature of this queue. This change removes two of the uses where we only check if the queue is empty by calling the "isEmpty()" method instead.