-
Notifications
You must be signed in to change notification settings - Fork 25.3k
[ML] Remove Voyageai request manager classes #124512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jonathan-buttner
merged 3 commits into
elastic:main
from
jonathan-buttner:ml-inference-remove-voyage-request-managers
Mar 13, 2025
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 0 additions & 57 deletions
57
.../elasticsearch/xpack/inference/external/http/sender/VoyageAIEmbeddingsRequestManager.java
This file was deleted.
Oops, something went wrong.
54 changes: 0 additions & 54 deletions
54
...n/java/org/elasticsearch/xpack/inference/external/http/sender/VoyageAIRequestManager.java
This file was deleted.
Oops, something went wrong.
56 changes: 0 additions & 56 deletions
56
.../org/elasticsearch/xpack/inference/external/http/sender/VoyageAIRerankRequestManager.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,10 +12,8 @@ | |
import org.elasticsearch.common.Strings; | ||
import org.elasticsearch.xpack.inference.external.request.HttpRequest; | ||
import org.elasticsearch.xpack.inference.external.request.Request; | ||
import org.elasticsearch.xpack.inference.external.voyageai.VoyageAIAccount; | ||
import org.elasticsearch.xpack.inference.services.voyageai.embeddings.VoyageAIEmbeddingsModel; | ||
import org.elasticsearch.xpack.inference.services.voyageai.embeddings.VoyageAIEmbeddingsServiceSettings; | ||
import org.elasticsearch.xpack.inference.services.voyageai.embeddings.VoyageAIEmbeddingsTaskSettings; | ||
|
||
import java.net.URI; | ||
import java.nio.charset.StandardCharsets; | ||
|
@@ -24,47 +22,43 @@ | |
|
||
public class VoyageAIEmbeddingsRequest extends VoyageAIRequest { | ||
|
||
private final VoyageAIAccount account; | ||
private final List<String> input; | ||
private final VoyageAIEmbeddingsServiceSettings serviceSettings; | ||
private final VoyageAIEmbeddingsTaskSettings taskSettings; | ||
private final String model; | ||
private final String inferenceEntityId; | ||
private final VoyageAIEmbeddingsModel embeddingsModel; | ||
|
||
public VoyageAIEmbeddingsRequest(List<String> input, VoyageAIEmbeddingsModel embeddingsModel) { | ||
Objects.requireNonNull(embeddingsModel); | ||
|
||
account = VoyageAIAccount.of(embeddingsModel); | ||
this.embeddingsModel = Objects.requireNonNull(embeddingsModel); | ||
this.input = Objects.requireNonNull(input); | ||
serviceSettings = embeddingsModel.getServiceSettings(); | ||
taskSettings = embeddingsModel.getTaskSettings(); | ||
model = embeddingsModel.getServiceSettings().getCommonSettings().modelId(); | ||
inferenceEntityId = embeddingsModel.getInferenceEntityId(); | ||
} | ||
|
||
@Override | ||
public HttpRequest createHttpRequest() { | ||
HttpPost httpPost = new HttpPost(account.uri()); | ||
HttpPost httpPost = new HttpPost(embeddingsModel.uri()); | ||
|
||
ByteArrayEntity byteEntity = new ByteArrayEntity( | ||
Strings.toString(new VoyageAIEmbeddingsRequestEntity(input, serviceSettings, taskSettings, model)) | ||
.getBytes(StandardCharsets.UTF_8) | ||
Strings.toString( | ||
new VoyageAIEmbeddingsRequestEntity( | ||
input, | ||
embeddingsModel.getServiceSettings(), | ||
embeddingsModel.getTaskSettings(), | ||
embeddingsModel.getServiceSettings().modelId() | ||
) | ||
).getBytes(StandardCharsets.UTF_8) | ||
); | ||
httpPost.setEntity(byteEntity); | ||
|
||
decorateWithHeaders(httpPost, account); | ||
decorateWithHeaders(httpPost, embeddingsModel); | ||
|
||
return new HttpRequest(httpPost, getInferenceEntityId()); | ||
} | ||
|
||
@Override | ||
public String getInferenceEntityId() { | ||
return inferenceEntityId; | ||
return embeddingsModel.getInferenceEntityId(); | ||
} | ||
|
||
@Override | ||
public URI getURI() { | ||
return account.uri(); | ||
return embeddingsModel.uri(); | ||
} | ||
|
||
@Override | ||
|
@@ -77,11 +71,7 @@ public boolean[] getTruncationInfo() { | |
return null; | ||
} | ||
|
||
public VoyageAIEmbeddingsTaskSettings getTaskSettings() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unused |
||
return taskSettings; | ||
} | ||
|
||
public VoyageAIEmbeddingsServiceSettings getServiceSettings() { | ||
return serviceSettings; | ||
return embeddingsModel.getServiceSettings(); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a helper that converts a URI exception to an
ElasticsearchStatusException
.