Skip to content

Commit edb3818

Browse files
authored
Disable TO_UPPER(null)-tests prior to 8.17 (#119213)
TO_UPPER/TO_LOWER resolution incorrectly returned child's type (that could also be `null`, type `NULL`), instead of KEYWORD/TEXT. So a test like `TO_UPPER(null) == "..."` fails on type mismatch. This was fixed collaterally by #114334 (8.17.0) Also, correct some of the tests skipping (that had however no impact, due to testing range).
1 parent 7ba3cb9 commit edb3818

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

x-pack/plugin/esql/qa/testFixtures/src/main/resources/string.csv-spec

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1231,7 +1231,7 @@ a:keyword | upper:keyword | lower:keyword
12311231
π/2 + a + B + Λ ºC | Π/2 + A + B + Λ ºC | π/2 + a + b + λ ºc
12321232
;
12331233

1234-
equalsToUpperPushedDown[skip:-8.12.99, reason:case insensitive operators implemented in v 8.13]
1234+
equalsToUpperPushedDown#[skip:-8.12.99, reason:case insensitive operators implemented in v 8.13]
12351235
from employees
12361236
| where to_upper(first_name) == "GEORGI"
12371237
| keep emp_no, first_name
@@ -1241,7 +1241,7 @@ emp_no:integer | first_name:keyword
12411241
10001 | Georgi
12421242
;
12431243

1244-
equalsToUpperNestedPushedDown[skip:-8.12.99, reason:case insensitive operators implemented in v 8.13]
1244+
equalsToUpperNestedPushedDown#[skip:-8.12.99, reason:case insensitive operators implemented in v 8.13]
12451245
from employees
12461246
| where to_upper(to_upper(to_lower(first_name))) == "GEORGI"
12471247
| keep emp_no, first_name
@@ -1251,7 +1251,7 @@ emp_no:integer | first_name:keyword
12511251
10001 | Georgi
12521252
;
12531253

1254-
negatedEqualsToUpperPushedDown[skip:-8.12.99, reason:case insensitive operators implemented in v 8.13]
1254+
negatedEqualsToUpperPushedDown#[skip:-8.12.99, reason:case insensitive operators implemented in v 8.13]
12551255
from employees
12561256
| sort emp_no
12571257
| where not(to_upper(first_name) == "GEORGI")
@@ -1263,7 +1263,7 @@ emp_no:integer | first_name:keyword
12631263
10002 | Bezalel
12641264
;
12651265

1266-
notEqualsToUpperPushedDown[skip:-8.12.99, reason:case insensitive operators implemented in v 8.13]
1266+
notEqualsToUpperPushedDown#[skip:-8.12.99, reason:case insensitive operators implemented in v 8.13]
12671267
from employees
12681268
| sort emp_no
12691269
| where to_upper(first_name) != "GEORGI"
@@ -1275,7 +1275,7 @@ emp_no:integer | first_name:keyword
12751275
10002 | Bezalel
12761276
;
12771277

1278-
negatedNotEqualsToUpperPushedDown[skip:-8.12.99, reason:case insensitive operators implemented in v 8.13]
1278+
negatedNotEqualsToUpperPushedDown#[skip:-8.12.99, reason:case insensitive operators implemented in v 8.13]
12791279
from employees
12801280
| sort emp_no
12811281
| where not(to_upper(first_name) != "GEORGI")
@@ -1306,7 +1306,7 @@ c:long
13061306
90
13071307
;
13081308

1309-
equalsToUpperNullFolded
1309+
equalsToUpperNullFolded#[skip:-8.16.99, reason:function's type corrected in #114334]
13101310
from employees
13111311
| where to_upper(null) == "Georgi"
13121312
| keep emp_no, first_name
@@ -1324,7 +1324,7 @@ from employees
13241324
emp_no:integer | first_name:keyword
13251325
;
13261326

1327-
notEqualsToUpperNullFolded
1327+
notEqualsToUpperNullFolded#[skip:-8.16.99, reason:function's type corrected in #114334]
13281328
from employees
13291329
| where to_upper(null) != "Georgi"
13301330
| keep emp_no, first_name
@@ -1362,7 +1362,7 @@ c:long
13621362
0
13631363
;
13641364

1365-
equalsToLowerPushedDown[skip:-8.12.99, reason:case insensitive operators implemented in v 8.13]
1365+
equalsToLowerPushedDown#[skip:-8.12.99, reason:case insensitive operators implemented in v 8.13]
13661366
from employees
13671367
| where to_lower(first_name) == "georgi"
13681368
| keep emp_no, first_name
@@ -1372,7 +1372,7 @@ emp_no:integer | first_name:keyword
13721372
10001 | Georgi
13731373
;
13741374

1375-
notEqualsToLowerPushedDown[skip:-8.12.99, reason:case insensitive operators implemented in v 8.13]
1375+
notEqualsToLowerPushedDown#[skip:-8.12.99, reason:case insensitive operators implemented in v 8.13]
13761376
from employees
13771377
| sort emp_no
13781378
| where to_lower(first_name) != "georgi"

0 commit comments

Comments
 (0)