Skip to content

Fixing nodes info response #4636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixing nodes info response #4636

wants to merge 2 commits into from

Conversation

l-trotta
Copy link
Contributor

From 1/112 validated responses to 112/112. Details:

  • Missing fields in NodeInfo -> server code
  • transport.ignore_deserialization_errors is said to be only used in unit tests, so I'm setting it as private -> server code
  • In NodeJvmInfo, bundled_jdk is not actually there, there's only using_bundled_jdk -> server code

@l-trotta l-trotta force-pushed the fixing-nodes-info-resp branch from b37952d to 902b212 Compare June 20, 2025 09:38
Copy link
Contributor

github-actions bot commented Jun 20, 2025

Following you can find the validation changes for the API you have modified.

API Status Request Response
nodes.info 🔴 → 🟢 112/112 1/112 → 112/112

You can validate this API yourself by using the make validate target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant