-
Notifications
You must be signed in to change notification settings - Fork 102
Remove Experimental Labels for SparseVectorQuery Token Pruning for GA #4454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
output/schema/schema.json
Outdated
"stack": { | ||
"since": "8.15.0", | ||
"stability": "experimental" | ||
"since": "8.15.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you automatically regenerate these files, or hand edit them? I think we still need the stack version information and I'm surprised if it got wiped out automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the CONTRIBUTING instructions and ran make contrib
-- should the since
label be updated to 8.19?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, because it's still available in previous APIs? Maybe we can get help from the clients team to confirm this is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends. If the API did not change since 8.15, then it's fine, otherwise we should switch to 8.19.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Also, sorry for the 2 weeks delay! Asking devtools-team for a review can help with faster review time, as there are many changes here owned by the docs team which we don't review.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends. If the API did not change since 8.15, then it's fine, otherwise we should switch to 8.19.
I think we're good unless there's a change I don't know about (@kderusso ?)
NOTE - do not merge until elastic/elasticsearch#128854 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
A small PR to remove the
stability=experimental
tags for the pruning configuration items for thesparse_vector
query type.