Skip to content

Introduce since, description and default tags #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 8, 2021
Merged

Introduce since, description and default tags #324

merged 10 commits into from
Apr 8, 2021

Conversation

delvedor
Copy link
Member

@delvedor delvedor commented Apr 8, 2021

Closes #251

philkra
philkra previously approved these changes Apr 8, 2021
Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor requested review from swallez and philkra April 8, 2021 16:59
swallez
swallez previously approved these changes Apr 8, 2021
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I like server_default much better!

@delvedor delvedor merged commit 6e6377a into master Apr 8, 2021
@delvedor delvedor deleted the fix-251 branch April 8, 2021 17:43
@delvedor delvedor mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default, Version & Description Parameter Annotations
3 participants