Skip to content

[MODEL] Fix import when preprocess returns empty collection #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

timbleck
Copy link
Contributor

Closes #719 and also fixes existing test on preprocess which had no effect.

@aeroastro
Copy link
Contributor

Great work!
I have been using 5.x version on production environment with a similar patch.
I'm wondering when this will be merged into all the elasticsearch-rails versions.

@aeroastro
Copy link
Contributor

@karmi

Could you take a short look into this?

@karmi
Copy link
Contributor

karmi commented Apr 25, 2018

@timbleck , @aeroastro , sorry for the long silence here! As I've mentioned on other tickets, we're scheduling a significant effort to give attention to the elassticsearch-rails groups of libraries again in couple of weeks, so I'd rather not merge the PR now, but wait a bit, until we have more capacity and focus to be more organized with that...

@estolfo
Copy link
Contributor

estolfo commented Sep 7, 2018

thanks @timbleck !

@estolfo estolfo merged commit 154cd79 into elastic:2.x Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants