Proxy object destroys inheritance feature #585
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests worked great when the objects just had
Elasticsearch::Model::Naming
methods included, but that's not how Elasticsearch is used in real life. In real life, the index_name and document_name are accessed through a proxy, and the tree search was not considering that. This adds tests to confirm the infinite loop that this caused, and then fixes it by checking against the proxy object's target.