You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While I can still pass in an explicit :index, all arguments are ignored and the repositories index_name is used instead.
This is a bit surprising, I would expect the method to either use the passed in argument or raise an ArgumentError if passing an index name is not desired.
The text was updated successfully, but these errors were encountered:
fnordfish
changed the title
Elasticsearch::Persistence::Repository
Elasticsearch::Persistence::Repository#index_exists? silently drops arguments
Oct 17, 2018
Hi @fnordfish Thanks for reporting this! I've opened a pull request to fix it here
Can you try it out in your testing environment and let me know if it resolves the issue for you? Thanks!
I was just upgrading and ran into an issues when trying to use
my_repository.index_exists?(index: "my_index_name")
In https://github.com/elastic/elasticsearch-rails/blob/master/elasticsearch-persistence/lib/elasticsearch/persistence/repository.rb#L213-L215
While I can still pass in an explicit
:index
, all arguments are ignored and the repositories index_name is used instead.This is a bit surprising, I would expect the method to either use the passed in argument or raise an ArgumentError if passing an index name is not desired.
The text was updated successfully, but these errors were encountered: