Support "wrapper" option

[benjaminbarbe]

Wrapping with Hashie::Mash can be slow (~ 4s)

Versus extend method (but it won't allow deeper hierarchies ~ 0.26s)

One option would be to support "wrapper" option, which could be Hash, Hashie::Mash, custom object...
Elasticsearch::Model.wrapper = Hash

[karmi]

Thanks!, and sorry for not getting to you sooner. This makes of course a lot of sense, and we should support it. wrapper might be too generic I guess, maybe result_wrapper? Also, I think it should be a valid option for searches, so you can change it on a case-by-case basis.

[edgurgel]

Shouldn't this be on elasticsearch-ruby "level" too? (Maybe stupid idea)

I would love to client.search(...., wrapper: ...)

[karmi]

@edgurgel That's precisely what I wouldn't do :) The Ruby client is intentionally "low level", and is designed as a tool for users, as something to build their own codebase with. Notice that we include instructions about wrapping results in the README for elasticsearch-api: https://github.com/elasticsearch/elasticsearch-ruby/tree/master/elasticsearch-api#using-hash-wrappers

@benjaminbarbe On a vacation until late August, will look at this as soon as I'm operational, this is an important configuration option.

[edgurgel]

@karmi yeah I can understand the reason. I missed the point :P

[benjaminbarbe]

@karmi Thanks 😄 Enjoy your holiday.

[fbernier]

This would indeed be a useful feature. Would you still accept a PR for this?

[Animeye]

Has there been any further information on this?

[karmi]

@Animeye No new information, this fell off the radar... If anybody would like to pick it up (@fbernier), I'm up for assistance and review!

[martinemde]

@karmi I submitted a partial fix for this in #755. Hopefully it can address some of the concerns in this thread.

[bkazez]

I'm still seeing large performance issues due to Hashie::Mash on the 5.x branch for a Elasticsearch::Persistence::Model class - see below. What is the recommended workaround?

[martinemde]

@bkazez I monkeypatched the gem for now to remove the wrapping in a Hashie::Mash. It has made a big difference for me. I also submitted #755 to attempt to deal with it without breaking anything.

btw, here's the monkeypatch we are using in our production app:

MonkeyPatch.for('elasticsearch-persistence', '<your gem version here>') do
  module Elasticsearch
    module Persistence
      module Repository
        module Response # :nodoc:
          class Results
            # This patch removes the usage of Hashie::Mash which is very very slow
            # and provides us no value. As of 2017-11-15, the newest version of
            # elasticsearch-persistence gem still has a compatible initialize
            # method that won't be broken by this patch.
            #
            # https://github.com/elastic/elasticsearch-rails/blob/master/elasticsearch-persistence/lib/elasticsearch/persistence/repository/response/results.rb
            #
            def initialize(repository, response, options={})
              @repository = repository
              # This is the only change:
              #@response   = Hashie::Mash.new(response) # Comment this line
              @response   = response # Add this line.
              @options    = options
            end
          end
        end
      end
    end
  end
end