Skip to content

Update basic-config.asciidoc #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 5, 2023
Merged

Update basic-config.asciidoc #1832

merged 6 commits into from
Apr 5, 2023

Conversation

nicoandmee
Copy link
Contributor

fix missing comma

Just fixing a missing comma 😅

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Mar 28, 2023 •
edited
Loading

💚 CLA has been signed

JoshMock
JoshMock approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution @nicoandmee! All contributions are helpful, large or small. 🙂

Please do sign that CLA mentioned below so we can get this merged. 🙏

@JoshMock JoshMock changed the base branch from 8.6 to main March 30, 2023 15:32
@JoshMock
Copy link
Member

@nicoandmee I also noticed you were targeting the 8.6 branch so I changed to merge into main. Can you rebase your branch and sign that CLA and I'll merge this for you.

@nicoandmee
Copy link
Contributor Author

@nicoandmee I also noticed you were targeting the 8.6 branch so I changed to merge into main. Can you rebase your branch and sign that CLA and I'll merge this for you.

Hi! I have now done so. For some reason the CLA didn't take the first time 🤷
Cheers

@JoshMock
Copy link
Member

JoshMock commented Apr 5, 2023

jenkins test this

@JoshMock JoshMock merged commit a4ceb47 into elastic:main Apr 5, 2023
@JoshMock
Copy link
Member

JoshMock commented Apr 5, 2023

Thanks again for your contribution, @nicoandmee.

@JoshMock JoshMock mentioned this pull request Apr 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshMock JoshMock JoshMock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicoandmee @elasticmachine @JoshMock @Anaethelion @szabosteve