Updated abort behavior

[delvedor]

This pr contains a few feature and fixes:

Features

• Added support for aborting a request with the promise style API
• Added RequestAbortedError constructor.

Fixes

• Until now, aborting a request was blocking the HTTP request, but never calling the callback or resolving the promise to notify the user. This is a bug because it could lead to dangerous memory leaks. From now on if the user calls the request.abort() method, the callback style API will be called with a RequestAbortedError, the promise will be rejected with RequestAbortedError as well.
• The Connection class wasn't consistent regarding errors, as it could return both Node.js errors or client errors (in case of timeouts). With this pr now it only returns client errors, namely ConnectionError, TimeoutError and RequestAbortedError.

Closes #1070

[penge]

I have some general questions. I hope it's fine to ask here :) (or, is there a better channel for this?)

Questions would be:

1. Is there a particular reason why d.ts files are in repository? More here:

   • https://stackoverflow.com/questions/32758766/should-i-check-my-typescript-definition-files-for-external-libraries-into-git

   • https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html

   • https://github.com/DefinitelyTyped/DefinitelyTyped

2. How are d.ts files generated? Are they generated manually?

3. Why not having tsconfig.json and ts files?

Thanks! :)

[penge]

The condition !aborted is in if but its handler is in else.

Better would be to put it together, and at the top, as a guard clause.

if (aborted) {
  callback(new RequestAbortedError(), null)
  return
}

callback(null, stream)

[delvedor]

Tomayto, tomahto :)
You can read it in both ways, if the operation has not been aborted, then continue, otherwise return a RequestAbortedError error.

[penge]

Read it, I can. Merge it, we can:)

[delvedor]

I have some general questions. I hope it's fine to ask here :) (or, is there a better channel for this?)

@penge given that these questions are not related t this pr, I would kindly ask you to open an issue :)

[github-actions]

The backport to 7.x failed:

The process 'git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.x 7.x
# Navigate to the new working tree
cd .worktrees/backport-7.x
# Create a new branch
git switch --create backport-1141-to-7.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 27a8e2a9bf614224a96bf44293ace8a112ec8677
# Push it to GitHub
git push --set-upstream origin backport-1141-to-7.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.x

Then, create a pull request where the base branch is 7.x and the compare/head branch is backport-1141-to-7.x.