TypeError: Cannot read property 'resurrectTimeout' of undefined at ConnectionPool.resurrect

[kokozhang]

🐛 Bug Report

Hello. When I called esClint.index() I got:
this.connections.get(this.dead[0]) is undefined at ConnectionPool.js

To Reproduce

Steps to reproduce the behavior:

const elasticsearch = require('@elastic/elasticsearch');

const esClient = new elasticsearch.Client({ node: ESHost.split(',').map(host => host.startsWith('http://') ? host : `http://${host}`), sniffOnStart: true });

esClient.index(q)

Expected behavior

Index this document. And Code compiles without error

Actual behavior

TypeError: Cannot read property 'resurrectTimeout' of undefined
    at ConnectionPool.resurrect (/var/task/node_modules/@elastic/elasticsearch/lib/ConnectionPool.js:124:47)
    at Transport.getConnection (/var/task/node_modules/@elastic/elasticsearch/lib/Transport.js:332:25)
    at makeRequest (/var/task/node_modules/@elastic/elasticsearch/lib/Transport.js:124:30)
    at Transport.request (/var/task/node_modules/@elastic/elasticsearch/lib/Transport.js:316:15)
    at Promise (/var/task/node_modules/@elastic/elasticsearch/lib/Transport.js:90:14)
    at new WrappedPromise (/var/task/node_modules/async-listener/es6-wrapped-promise.js:13:18)
    at Transport.request (/var/task/node_modules/@elastic/elasticsearch/lib/Transport.js:89:14)
    at _index (/var/task/node_modules/@elastic/elasticsearch/api/api/index.js:148:12)
    at Client._lazyLoad [as index] 

Your Environment

• node version: 8
• @elastic/elasticsearch version: 6.8.1
• os: Linux
• Deployed in Lambda

[delvedor]

Hello!
I'm not able to reproduce the issue on my local machine, can you that with https://github.com/delvedor/es-reproduce-issue?

[ganxiyun]

How to reproduce

1. ESHost list is provided in initialization
2. sniffOnStart is true
3. one connection returns error response so the connection is marked as dead before the finish of update (connections)

#946

This pull request can reveal the issue better

[delvedor]

Are you able to reproduce it also with the latest release of the client?
It looks like that the issue is caused by the "old" implementation of the connection pool (previous to #913) where the dead queue was not cleaned up after an update.

The current implementation, which has been released in 6.8.2 and 7.3.0, should fix your problem. Are you able to reproduce the issue even with the latest version?
If so, can you use https://github.com/delvedor/es-reproduce-issue to show how to reproduce the issue?
Thanks!

[JerseyGood]

@delvedor
The new code did clean up the dead list in update but isn't this change array while looping risky?

elasticsearch-js/lib/pool/ConnectionPool.js

Line 218 in a4bff1c

this.dead.splice(i, 1)

Suppose you got 2 dead connections that are not tracked by this.connections,
wouldn't the 2nd splice delete the wrong index?

[ganxiyun]

Are you able to reproduce it also with the latest release of the client?
It looks like that the issue is caused by the "old" implementation of the connection pool (previous to #913) where the dead queue was not cleaned up after an update.

The current implementation, which has been released in 6.8.2 and 7.3.0, should fix your problem. Are you able to reproduce the issue even with the latest version?
If so, can you use https://github.com/delvedor/es-reproduce-issue to show how to reproduce the issue?
Thanks!

I have created test cases, could you please have a check?

(I force pushed the branch I created, not good action, but it's good for the review)

[stale]

We understand that this might be important for you, but this issue has been automatically marked as stale because it has not had recent activity either from our end or yours.
It will be closed if no further activity occurs, please write a comment if you would like to keep this going.

Note: in the past months we have built a new client, that has just landed in master. If you want to open an issue or a pr for the legacy client, you should do that in https://github.com/elastic/elasticsearch-js-legacy

[stale]

We understand that this might be important for you, but this issue has been automatically marked as stale because it has not had recent activity either from our end or yours.
It will be closed if no further activity occurs, please write a comment if you would like to keep this going.

Note: in the past months we have built a new client, that has just landed in master. If you want to open an issue or a pr for the legacy client, you should do that in https://github.com/elastic/elasticsearch-js-legacy