Skip to content

remove DSL code and redirect imports to unified Python client #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 16, 2025

Conversation

miguelgrinberg
Copy link
Collaborator

@miguelgrinberg miguelgrinberg commented Feb 4, 2025

This PR removes all the code from the Elasticsearch DSL library and replaces it with redirects to the same code now located in the Python client (https://github.com/elastic/elasticsearch-py).

I'm leaving the unit tests untouched, to confirm that the import redirects work well.

Must be merged after the unified client is released. Until then, to avoid failures the dependency on the Python client was changed to install the main branch.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. 🎉

@miguelgrinberg miguelgrinberg force-pushed the dsl-import-redirect branch 2 times, most recently from cbc3e03 to 4f5703d Compare April 4, 2025 16:21
@miguelgrinberg miguelgrinberg added the backport 8.x Backport to 8.x label Apr 16, 2025
@miguelgrinberg miguelgrinberg merged commit 9e52595 into elastic:main Apr 16, 2025
19 checks passed
@miguelgrinberg miguelgrinberg deleted the dsl-import-redirect branch April 16, 2025 11:03
github-actions bot pushed a commit that referenced this pull request Apr 16, 2025
* remove DSL code and redirect imports to unified Python client

* add note about merge in README

* install main branch from client until 9.0 is released

* make version reporting backwards compatible

* add missing readthedocs configuration for sphinx

* fix readme note formatting

* linter fix

* deprecation notice in the docs

(cherry picked from commit 9e52595)
miguelgrinberg added a commit that referenced this pull request Apr 16, 2025
… client (#1972)

* remove DSL code and redirect imports to unified Python client (#1968)

* remove DSL code and redirect imports to unified Python client

* add note about merge in README

* install main branch from client until 9.0 is released

* make version reporting backwards compatible

* add missing readthedocs configuration for sphinx

* fix readme note formatting

* linter fix

* deprecation notice in the docs

(cherry picked from commit 9e52595)

* Fix 9.0 documentation link

* Use 8.x client for tests

---------

Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 8.x Backport to 8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants