-
Notifications
You must be signed in to change notification settings - Fork 801
remove DSL code and redirect imports to unified Python client #1968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
miguelgrinberg
merged 8 commits into
elastic:main
from
miguelgrinberg:dsl-import-redirect
Apr 16, 2025
Merged
remove DSL code and redirect imports to unified Python client #1968
miguelgrinberg
merged 8 commits into
elastic:main
from
miguelgrinberg:dsl-import-redirect
Apr 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92942ea
to
41d4dce
Compare
e2c1a6d
to
f6cac5d
Compare
pquentin
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. 🎉
cbc3e03
to
4f5703d
Compare
4f5703d
to
5ac5ea4
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
* remove DSL code and redirect imports to unified Python client * add note about merge in README * install main branch from client until 9.0 is released * make version reporting backwards compatible * add missing readthedocs configuration for sphinx * fix readme note formatting * linter fix * deprecation notice in the docs (cherry picked from commit 9e52595)
miguelgrinberg
added a commit
that referenced
this pull request
Apr 16, 2025
… client (#1972) * remove DSL code and redirect imports to unified Python client (#1968) * remove DSL code and redirect imports to unified Python client * add note about merge in README * install main branch from client until 9.0 is released * make version reporting backwards compatible * add missing readthedocs configuration for sphinx * fix readme note formatting * linter fix * deprecation notice in the docs (cherry picked from commit 9e52595) * Fix 9.0 documentation link * Use 8.x client for tests --------- Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all the code from the Elasticsearch DSL library and replaces it with redirects to the same code now located in the Python client (https://github.com/elastic/elasticsearch-py).
I'm leaving the unit tests untouched, to confirm that the import redirects work well.
Must be merged after the unified client is released. Until then, to avoid failures the dependency on the Python client was changed to install the main branch.