Add rank option to elasticsearch_dsl.search.Search
#1692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this and will want it when |
miguelgrinberg
force-pushed
the
rank-option
branch
2 times, most recently
from
776bfd0 to
212e830
Compare
miguelgrinberg
force-pushed
the
rank-option
branch
from
212e830 to
f853371
Compare
|
@pquentin This is now ready. I left the docstring docs, including a note about RRF being in preview. |
pquentin
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Thanks! LGTM. I was able to use this in the "Hybrid Search using RRF" notebook:
import json
from elasticsearch_dsl import Search
s = Search(using=client, index="book_index")
s = s[:5]
s = s.query("match", summary="python programming")
s = s.knn(
field="title_vector",
# generate embedding for query so it can be compared to `title_vector`
query_vector=model.encode("python programming").tolist(),
k=5,
num_candidates=10,
)
s = s.rank(rrf={})
r = s.execute()
pretty_response(r)
pquentin
pushed a commit
that referenced
this pull request
Jan 5, 2024
…`` (#1692) (#1694) (cherry picked from commit 5422cf0) Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
rankoption, to enable the use of the RRF algorithm to combine multiple sets of search results. Not sure if we want this published, given thatrankis in technical preview at this point, but since I have implemented it for my own use I'm sharing the changes here.