-
Notifications
You must be signed in to change notification settings - Fork 17
feat: release process #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will be another follow-up with the changes in
elastic-otel-java/.ci/release.sh
Lines 31 to 32 in 8fcbb73
### TODO: changeme | |
publishArg='assemble' |
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @amannocci for this! 💯
As I mentioned in a previous comment,
elastic-otel-java/.ci/release.sh
Lines 31 to 32 in 8fcbb73
### TODO: changeme | |
publishArg='assemble' |
In a follow-up, so we play safe?
@SylvainJuge, what's the required target goal? The same as
elastic-otel-java/.ci/snapshot.sh
Line 31 in dc4c6ea
publishArg='publishToSonatype closeAndReleaseStagingRepository' |
It's the same as the snapshot, so:
When run with a non-snapshot version it should publish to the releases repository. |
Signed-off-by: Adrien Mannocci <[email protected]>
Ref: e1864cd |
What is the change being made?
Why is the change being made?