Skip to content

feat: release process #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 23, 2024
Merged

feat: release process #145

merged 11 commits into from
Feb 23, 2024

Conversation

amannocci
Copy link
Contributor

@amannocci amannocci commented Feb 22, 2024

What is the change being made?

  • Implement full release process.

Why is the change being made?

  • Add the ability to release a new version without lifting branch protections.

Signed-off-by: Adrien Mannocci <[email protected]>
@amannocci amannocci marked this pull request as ready for review February 23, 2024 10:51
@amannocci amannocci changed the title WIP feat: release process feat: release process Feb 23, 2024
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be another follow-up with the changes in

### TODO: changeme
publishArg='assemble'
, won't it?

Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @amannocci for this! 💯

As I mentioned in a previous comment,

### TODO: changeme
publishArg='assemble'
will need to be accommodated to run the release.

In a follow-up, so we play safe?

@SylvainJuge, what's the required target goal? The same as

publishArg='publishToSonatype closeAndReleaseStagingRepository'
?

@SylvainJuge
Copy link
Member

@SylvainJuge, what's the required target goal? The same as

publishArg='publishToSonatype closeAndReleaseStagingRepository'

?

It's the same as the snapshot, so:

 publishArg='publishToSonatype closeAndReleaseStagingRepository'

When run with a non-snapshot version it should publish to the releases repository.

@amannocci
Copy link
Contributor Author

amannocci commented Feb 23, 2024

@SylvainJuge, what's the required target goal? The same as

publishArg='publishToSonatype closeAndReleaseStagingRepository'

?

It's the same as the snapshot, so:

 publishArg='publishToSonatype closeAndReleaseStagingRepository'

When run with a non-snapshot version it should publish to the releases repository.

Ref: e1864cd

@SylvainJuge SylvainJuge merged commit f1d56bc into main Feb 23, 2024
@SylvainJuge SylvainJuge deleted the feat/release-process branch February 23, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants