Skip to content

Revert "[8.x](backport #7474) Switch to NewGCMWithRandomNonce for fips" #7740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

michel-laterman
Copy link
Contributor

Reverts #7549

aes.Block typecheck fails when built with microsoft/go due to the boring crypto patch used by microsoft.

This is likely an occurrence of an upstream issue

@michel-laterman michel-laterman added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team backport labels Apr 7, 2025
@michel-laterman michel-laterman requested a review from a team as a code owner April 7, 2025 20:54
@michel-laterman michel-laterman requested review from pkoutsovasilis and kaanyalti and removed request for a team April 7, 2025 20:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link

Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however are we avoiding to do revert PRs with the usual backport process (other PR)? 🙂

@michel-laterman michel-laterman merged commit 632dc59 into 8.x Apr 9, 2025
15 checks passed
@michel-laterman michel-laterman deleted the revert-7549-mergify/bp/8.x/pr-7474 branch April 9, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants