Pull in event.dataset for log correlation
#40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
sethmlarson
approved these changes
Mar 8, 2021
|
Currently we don't have any tests against log correlation -- do we want to try to test against the actual log record factory in the Python Agent or just create mock a log record with these fields? "Best" vs "easy" ;) Edit: ref elastic/apm-agent-python#1061 if we want to test against the upstream implementation |
|
@basepi We can rely on visual inspection here I think :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will just be
${service.name}.log, so pretty redundant but perhaps there will be a reason to have it configurable separate fromservice.namein the future? In any case, it's defined in the spec.