Skip to content

[DOCS] Add link to APM python LOG_ECS_FORMATTING #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Mar 8, 2021

@bmorelli25 There's probably a better way to do this than with the full link. Especially because the full link points to master, not current, since current doesn't have it yet.

Closes elastic/apm-agent-python#1007

@basepi basepi requested review from bmorelli25 and sethmlarson March 8, 2021 17:01
@apmmachine
Copy link
Contributor

apmmachine commented Mar 8, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #39 updated

  • Start Time: 2021-03-11T16:03:55.548+0000

  • Duration: 8 min 11 sec

  • Commit: 15c5783

Test stats 🧪

Test Results
Failed 0
Passed 237
Skipped 4
Total 241

Trends 🧪

Image of Build Times

Image of Tests

@bmorelli25
Copy link
Member

Unfortunately, there isn't much we can do to make this better. We have attributes for cross-doc python agent links like this, but as you've noticed they only point to current. This link will need to be updated to use the apm-py-ref attribute after the AUTO_ECS_LOGGING feature releases.

@basepi basepi changed the title [DOCS] Add link to APM python AUTO_ECS_LOGGING [DOCS] Add link to APM python LOG_ECS_FORMATTING Mar 11, 2021
@basepi basepi merged commit 503b927 into elastic:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[META 373] Extend ECS logging documentation
4 participants