Skip to content

Add support for Elastic APM log correlation #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Jul 23, 2020

Grabs elasticapm_span_id, elasticapm_transaction_id, and elasticapm_trace_id from LogRecord which are automatically added by elastic-apm and places the values into ECS tracing fields span.id, transaction.id, and trace.id so logs can be correlated to spans and traces.

Closes #13

@sethmlarson sethmlarson requested a review from basepi July 23, 2020 17:17
@apmmachine
Copy link
Contributor

apmmachine commented Jul 23, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #17 updated]

  • Start Time: 2020-07-31T21:24:48.183+0000

  • Duration: 16 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 146
Skipped 5
Total 151

@sethmlarson sethmlarson force-pushed the apm-log-correlation branch 2 times, most recently from 12a50f0 to 2fdd241 Compare July 23, 2020 18:48
Copy link

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethmlarson sethmlarson force-pushed the apm-log-correlation branch from 2fdd241 to d1078dc Compare July 31, 2020 21:24
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@sethmlarson sethmlarson merged commit aa6c4d8 into elastic:master Aug 3, 2020
@sethmlarson sethmlarson deleted the apm-log-correlation branch August 3, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transform Elastic APM tracing fields into ECS fields
4 participants