Fix for issue #92 : when trying to serialize null, serialize it as th…

[nhurion]

…e string "null"

When trying to serialize a CharSequence that is null, serialize it as the string null.
To avoid null checks propagation.

[cla-checker-service]

💚 CLA has been signed

[apmmachine]

💚 Build Succeeded

Expand to view the summary

Build stats

• Build Cause: [Started by user Felix Barnsteiner, Replayed #2]

• Start Time: 2020-09-29T07:49:29.779+0000

• Duration: 6 min 47 sec

Test stats 🧪

Test	Results
Failed	0
Passed	105
Skipped	4
Total	109

[nhurion]

I tried to sign the CLA multiple times, always having session timeout.

[felixbarny]

Thanks for the PR ❤️

Could you add a test case for using a null value in co.elastic.logging.EcsJsonSerializer#serializeFormattedMessage?

Hm, maybe try to sign the CLA again tomorrow.

[nhurion]

I added a unit test, and actually fixed the issue now.
For the CLA I downloaded the signed document so I assume it is in order now.
I tried to sign the CLA wit another e-mail address.

[nhurion]

Tried CLA again, dunno what more I can do.

[nhurion]

Is there any way to make this thing move forward? This bug is really problematic as it prevent normal error flow.

[nhurion]

I think the CLA passed this time

[nhurion]

I don't know what else to do to make this check pass. Anyone can help?

[felixbarny]

Hey, I just returned from PTO.

I've let the CLA check run again but it seems like it did not work.

Please make sure you're using the email address that's used in git (https://patch-diff.githubusercontent.com/raw/elastic/ecs-logging-java/pull/93.patch) and that this email is also associated with your GitHub account (https://github.com/settings/emails).

[nhurion]

I associated the email and signed with that email. Hopefully this one will work.

[felixbarny]

It did work! 🎉

[felixbarny]

Thank you for your contribution!

I've released a new version: https://github.com/elastic/ecs-logging-java/releases/tag/v0.5.2