Skip to content

Commit 59992e8

Browse files
authored
[release] improve release steps naming (#260)
1 parent e34d8a5 commit 59992e8

File tree

4 files changed

+34
-3
lines changed

4 files changed

+34
-3
lines changed

.github/workflows/README.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
### Release process
2+
3+
To release a new version of ecs-logging-java, you must use the two GitHub Workflows.
4+
5+
- Trigger the `release-step-1` GH workflow
6+
- parameters: version to release
7+
- will open `release-step-2` PR
8+
- Review and merge the `release-step-2` PR to `main` (version bump to release)
9+
- Trigger the `release-step-3` GH workflow
10+
- parameters: version to release and the `main` branch (or merge commit/ref of `release-step-2` PR merge).
11+
- will generate and publish release artifact through buildkite.
12+
- will open `release-step-4` PR
13+
- Review and merge the `release-step-4` PR to `main` (version bump from release to next snapshot version)
14+
15+
The tag release follows the naming convention: `v.<major>.<minor>.<patch>`, where `<major>`, `<minor>` and `<patch>`.
16+
17+

.github/workflows/pre-post-release.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,14 @@ on:
1717
description: 'Pre or post release phase'
1818
type: string # valid values are 'pre' or 'post'
1919
required: true
20+
pr_title:
21+
description: 'pull-request title'
22+
type: string
23+
required: true
24+
pr_body:
25+
description: : 'pull-request body'
26+
type: string
27+
required: true
2028

2129
env:
2230
RELEASE_VERSION: ${{ inputs.version }}
@@ -91,4 +99,4 @@ jobs:
9199
git push origin ${{ env.BRANCH_NAME }}
92100
93101
- name: Create the ${{ inputs.phase }} release PR
94-
run: gh pr create --title="${{ inputs.phase }} release v${{ env.RELEASE_VERSION }}" --base main --head ${{ env.BRANCH_NAME }} -b "${{ inputs.phase }} release v${{ env.RELEASE_VERSION }}"
102+
run: gh pr create --title="${{ inputs.pr_title }}" --base main --head ${{ env.BRANCH_NAME }} -b "${{ inputs.pr_body }}"

.github/workflows/pre-release.yml renamed to .github/workflows/release-step-1.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
name: Pre release
2+
name: release-step-1
33

44
on:
55
workflow_dispatch:
@@ -28,4 +28,8 @@ jobs:
2828
ref: ${{ inputs.ref }}
2929
version: ${{ inputs.version }}
3030
phase: 'pre'
31+
pr_title: "[release] release-step-2 ${{ inputs.version }}"
32+
pr_body: "Step 2 of the release process for version ${{ inputs.version }}: review & merge, then execute 'release-step-3' GH workflow"
3133
secrets: inherit
34+
35+
# TODO: rename PR "release step 2"

.github/workflows/release.yml renamed to .github/workflows/release-step-3.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
name: Release
2+
name: release-step-3
33

44
on:
55
workflow_dispatch:
@@ -164,4 +164,6 @@ jobs:
164164
ref: ${{ inputs.ref }}
165165
version: ${{ inputs.version }}
166166
phase: 'post'
167+
pr_title: "[release] release-step-4 ${{ inputs.version }}"
168+
pr_body: "Step 4 of the release process for version ${{ inputs.version }}: review & merge"
167169
secrets: inherit

0 commit comments

Comments
 (0)