Skip to content

Switch the APM Agent for Java to Asciidoctor #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Mar 12, 2019

Switches the core of the documentation build infrasturcture for the APM
Agent for Java from the no-longer-living AsciiDoc project to the active
Asciidoctor project. The HTML differences are fairly small:

  1. Empty table blocks no longer contain an <p></p>
  2. Headings are now in a <thead> tag.

Switches the core of the documentation build infrasturcture for the APM
Agent for Java from the no-longer-living AsciiDoc project to the active
Asciidoctor project. The HTML differences are fairly small:
1. Empty table blocks no longer contain an `<p></p>`
2. Headings are now in a `<thead>` tag.
@nik9000
Copy link
Member Author

nik9000 commented Mar 12, 2019

Here is a gist containing the difference, ignoring things that are invisible when the html is rendered or are a net positive like a few extra zero-width-spaces.

@nik9000 nik9000 mentioned this pull request Mar 12, 2019
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm guessing you're aware, but looks like there are some very slight table css changes too - they look good.

Edit: ah yes because of the <thead> tag!

Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I even prefer the new styling of the table where the first row has is now bold. Thanks again for making the docs repo more lightweight and trying out the new build so seamless ❤️

@nik9000 nik9000 merged commit cec5c91 into elastic:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants