Asciidoctor: Fix crash on broken definition lists #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our `TreeProcessorScaffold` would crash on definition lists where a term
wasn't matched with a definition. While these *are* broken definition
lists it is not ok for us to crash on them. This skips processing the
`nil` block that comes from such lists.
At this point the Elasticsearch reference builds, though it builds with
quite a few errors. The difference in performance is not as amazing
as the java-rest client but it is still substantial:
Asciidoctor Asciidoc
real 1m01.913s 3m09.738s
user 0m55.742s 3m02.545s
sys 0m02.910s 0m04.420s
So about 1/3 the time. For reference, this is the java rest client:
Asciidoctor Asciidoc
real 0m10.341s 1m05.432s
user 0m09.497s 0m55.270s
sys 0m00.616s 0m7.758s
Which, I suppose, is still just 1/6.
Closed
ddillinger
approved these changes
Jan 18, 2019
|
Thanks for reviewing @ddillinger! |
bmorelli25
pushed a commit
to bmorelli25/docs
that referenced
this pull request
Feb 15, 2019
Our `TreeProcessorScaffold` would crash on definition lists where a term
wasn't matched with a definition. While these *are* broken definition
lists it is not ok for us to crash on them. This skips processing the
`nil` block that comes from such lists.
At this point the Elasticsearch reference builds, though it builds with
quite a few errors. The difference in performance is not as amazing
as the java-rest client but it is still substantial:
Asciidoctor Asciidoc
real 1m01.913s 3m09.738s
user 0m55.742s 3m02.545s
sys 0m02.910s 0m04.420s
So about 1/3 the time. For reference, this is the java rest client:
Asciidoctor Asciidoc
real 0m10.341s 1m05.432s
user 0m09.497s 0m55.270s
sys 0m00.616s 0m7.758s
Which, I suppose, is still just 1/6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
TreeProcessorScaffoldwould crash on definition lists where a termwasn't matched with a definition. While these are broken definition
lists it is not ok for us to crash on them. This skips processing the
nilblock that comes from such lists.At this point the Elasticsearch reference builds, though it builds with
quite a few errors. The difference in performance is not as amazing
as the java-rest client but it is still substantial:
So about 1/3 the time. For reference, this is the java rest client:
Which, I suppose, is still just 1/6. It certainly feels faster though.