Asciidoctor: Add "Edit Me" Links #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the missing "Edit Me" links to every section. It uses a tree processor that modifies how some parts of Asciidoctor's AST render their titles to render the link.
nik9000
commented
Jan 4, 2019
| '-a' => 'root_dir=' . $root_dir, | ||
| $private ? ( '-a' => 'edit_url!' ) : (), | ||
| $private ? () : ( '-a' => "edit_url=$edit_url" ), |
There was a problem hiding this comment.
I've flipped this around because just the presence of the edit_url attribute is enough for asciidoctor.
|
Thanks for reviewing @ddillinger! |
Closed
bmorelli25
pushed a commit
to bmorelli25/docs
that referenced
this pull request
Feb 15, 2019
This adds the missing "Edit Me" links to every section. It uses a tree processor that modifies how some parts of Asciidoctor's AST render their titles to render the link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the missing "Edit Me" links to every section. It uses a tree
processor that modifies how some parts of Asciidoctor's AST render their
titles to render the link.