Switch Japanese XPack docs to Asciidoctor #1199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are very, very old but we'd still like to be able to build them with Asciidoctor so we can drop support for AsciiDoc all together.
Closed
|
That failure was broken links. I bet the links will need a non-breaking space like I added to the Chinese PHP api. |
Zero width space, actually. |
|
@elasticmachine, run elasticsearch-ci/docs |
3 similar comments
|
@elasticmachine, run elasticsearch-ci/docs |
|
@elasticmachine, run elasticsearch-ci/docs |
|
@elasticmachine, run elasticsearch-ci/docs |
|
The old docs look to be a bit of a mess and the diff looks a little nicer to be honest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are very, very old but we'd still like to be able to build
them with Asciidoctor so we can drop support for AsciiDoc all together.