Skip to content

Link current stack version instead feature releases. #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

mashhurs
Copy link
Contributor

@mashhurs mashhurs commented Apr 26, 2022

Description

When we support stack versions in VPR docs, we used (through our discussion) central release repo [master branch] to link. However, we checked that the master points to future releases, so that VPR docs should catch current stack release versions.
This PR introduces to replace master branch with current branch. Note that, current branch doc links to the current branch version doc, so that our logic pulls current version doc and retrieve stack versions from there.

Closes #74

Test

  • Manually running the VPR scrip on local and check if doc-tool can fetch current stack versions:
    Command: bundle exec ruby versioned_plugins.rb --repair --skip-existing --dry-run --output-path=../
    Output log:
mik$ bundle exec ruby versioned_plugins.rb --repair --skip-existing --dry-run --output-path=../
not using a github token
Current GitHub rate limit: 46/60
Warning! Api rate limit is close to being reached, this script may fail to execute
fatal: destination path '../logstash-docs' already exists and is not an empty directory.
Already on 'versioned_plugin_docs'
Logstash version: 8.1.3
ECS version: 8.1
writing to ../logstash-docs

Copy link

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mashhurs mashhurs merged commit 57efcc9 into elastic:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link current stack version instead feature releases.
3 participants