submit pr on versioned docs when build fails #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the versioned docs build script will compile the new docs, test them, and either: - abort the build if the test fails - submit a PR if the test passes Now that we have some confidence in the process (the build has been producing PRs for the past two months), this commit changes the behaviour to: - submit a PR if the test fails - commit directly if the test passes This way someone can manual fix the broken documentation directly in the PR instead of having to reproduce the failure locally.
|
@tsg thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the versioned docs build script will compile the new docs,
test them, and either:
Now that we have some confidence in the process (the build has been
producing PRs for the past two months), this commit changes the behaviour to:
This way someone can manual fix the broken documentation directly in the PR
instead of having to reproduce the failure locally.