Skip to content

ELASTIC_APM_RECORDING default value #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cmontanaro opened this issue Oct 27, 2020 · 1 comment · Fixed by #955
Closed

ELASTIC_APM_RECORDING default value #953

cmontanaro opened this issue Oct 27, 2020 · 1 comment · Fixed by #955
Assignees
@beniwohli

Comments

@cmontanaro
Copy link

Describe the bug:

Documentation states that the default value of ELASTIC_APM_RECORDING is false but default is set to true in code

To Reproduce

% grep -r RECORDING *
docs/configuration.asciidoc:| ELASTIC_APM_RECORDING | RECORDING | false
elasticapm/conf/init.py: recording = _BoolConfigValue("RECORDING", default=True)
@beniwohli beniwohli self-assigned this Oct 27, 2020
beniwohli added a commit to beniwohli/apm-agent-python that referenced this issue Oct 27, 2020
@beniwohli
fix documented default value for recording setting
efe62e2 
closes elastic#953
@beniwohli beniwohli mentioned this issue Oct 27, 2020
Merged
@beniwohli
Copy link
Contributor

@cmontanaro great catch! I opened #955 with the fix.

beniwohli added a commit that referenced this issue Oct 27, 2020
@beniwohli
fix documented default value for recording setting (#955)
a562dd9 
closes #953
beniwohli added a commit to beniwohli/apm-agent-python that referenced this issue Sep 14, 2021
@beniwohli
fix documented default value for recording setting (elastic#955)
2aeeae1 
closes elastic#953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beniwohli beniwohli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix documented default value for recording setting beniwohli/apm-agent-python
2 participants
@beniwohli @cmontanaro