Reconnect the connection thread if broker shuts down #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the subscriber and publisher interfaces more clear and stable.
Reconnect if the rabbitmq broker shuts down.
Configurable parameters for how many threads the subscriber is
allowed to create.
Keep track of published messages in order to requeue them if broker
goes down.
Create a base RabbitMQ class for shared methods.
Applicable Issues
fixes: #15
fixes: #16
Description of the Change
Reconnect the subscribers and publishers if RabbitMQ should go down for some reason.
Alternate Designs
Redesigned the code to utilize the SelectConnection instead of BlockingConnection of pika.
SelectConnection means async calls instead of sync calls of the BlockingConnection.
The BlockingConnection makes more understandable code whereas the SelectConnection is more reliable (We don't have to force thread-safety into a non-thread-safe tool).
Benefits
Reconnection is always good. More reliable code.
Possible Drawbacks
Could make it harder to maintain if one has problems with the SelectConnection.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson [email protected]